Now it looks like you are trying to return pointer to (void*), just remove that reference sign (&).



Thanks but, doesn't seem to be as straightforward... I need to revisit that code from Espressif's examples and see what they wanted to do in master_get_param_data and its interaction with the ...

Thanks chegewara, honored to get a reply from you, I casually check your IDF GH projects for reference and inspiration!


Thank you for kind words. I am constantly trying to improve my skills and i am sharing what i learned. Its because i could not learn that much without help and without ...

cppcheck does not find much on my code:


(base) rvalls@m1 esp-modbus-power-meter % /opt/homebrew/Cellar/cppcheck/2.9.1/bin/cppcheck --quiet --enable=all src 2> cppcheck.err
(base) rvalls@m1 esp-modbus-power-meter % cat cppcheck.err
src/app_modbus.c:45:59: portability: '(void*)&holding_reg_params ...

Hi,
i didnt study whole code, but it looks like you have created 2 tasks which should unlock each other with xTaskNotifyGive, but the problem is there is no initial notify and both task are awaiting in ulTaskNotifyTake:
https://github.com/brainstorm/esp-modbus-power-meter/blob/broken_tasks/src/app ...

Is there a forum to ask for code reviews for ESP-IDF application code? Anyways, I'm having some problems putting together Direct Task Notification scheme between two tasks: pvoutput and modbus over here:

https://github.com/brainstorm/esp-modbus-power-meter/blob/broken_tasks/src/app_modbus.c
https ...

EDIT: All fixed in https://github.com/brainstorm/esp-modbus-power-meter/commit/6520d32dc93cbe00fc9edb117dcc57f888515441, thanks Ivan! :)

Fixed all the remaining issues on this range of commits!: https://github.com/brainstorm/esp-modbus-power-meter/compare/f4a9b7afcc9a6206cf13e822c3b708d4697b2473 ...

Ivan, first of all, thanks for your invaluable help!

A couple of days ago, I reported the esp-insights error you mention and Vikram got it fixed and pushed upstream for me:

https://github.com/espressif/esp-insights/issues/12

I should have merged those changes before asking in here, my bad. Now ...

Hi,

I'm trying to refresh a ModBus+Power metering+Rainmaker/PVOutput hobby project of mine:

https://github.com/brainstorm/esp-modbus-power-meter/

The refresh I was thinking about consists on leaving PlatformIO part of it working with ESP-IDF 4.4 while transitioning to ESP-IDF 5.x SDK series. My ...

I've found out that the manual I just scanned and posted here is for the meter with model number YG899E-9SY, which does not correspond with my yigedianqi-modbus CID table because tha CID table I've written in my code is for model YG194E-9SY.

Both model's parameters seem to be laid out (correctly ...

Thanks for the detailed explanation, all doubts cleared, I will experiment further with that guidance :)

Now, if I may, I have one more question: I saw in the roadmap that timeseries is a planned feature and I've seen some hints on the properties of the API (i.e: PROP_FLAG_TIME_SERIES).

In my ...