Search found 27 matches

by brainstorm
Wed Nov 02, 2022 11:41 am
Forum: ESP-IDF
Topic: ESP-IDF FreeRTOS Task notification(s) code review?
Replies: 8
Views: 3054

Re: ESP-IDF FreeRTOS Task notification(s) code review?

Now it looks like you are trying to return pointer to (void*), just remove that reference sign (&). Thanks but, doesn't seem to be as straightforward... I need to revisit that code from Espressif's examples and see what they wanted to do in master_get_param_data and its interaction with the "parame...
by brainstorm
Wed Nov 02, 2022 11:19 am
Forum: ESP-IDF
Topic: ESP-IDF FreeRTOS Task notification(s) code review?
Replies: 8
Views: 3054

Re: ESP-IDF FreeRTOS Task notification(s) code review?

Thanks chegewara, honored to get a reply from you, I casually check your IDF GH projects for reference and inspiration! Thank you for kind words. I am constantly trying to improve my skills and i am sharing what i learned. Its because i could not learn that much without help and without other open ...
by brainstorm
Wed Nov 02, 2022 10:37 am
Forum: ESP-IDF
Topic: ESP-IDF FreeRTOS Task notification(s) code review?
Replies: 8
Views: 3054

Re: ESP-IDF FreeRTOS Task notification(s) code review?

cppcheck does not find much on my code: (base) rvalls@m1 esp-modbus-power-meter % /opt/homebrew/Cellar/cppcheck/2.9.1/bin/cppcheck --quiet --enable=all src 2> cppcheck.err (base) rvalls@m1 esp-modbus-power-meter % cat cppcheck.err src/app_modbus.c:45:59: portability: '(void*)&holding_reg_params' is ...
by brainstorm
Wed Nov 02, 2022 9:03 am
Forum: ESP-IDF
Topic: ESP-IDF FreeRTOS Task notification(s) code review?
Replies: 8
Views: 3054

Re: ESP-IDF FreeRTOS Task notification(s) code review? Better heap profiling tools?

Hi, i didnt study whole code, but it looks like you have created 2 tasks which should unlock each other with xTaskNotifyGive, but the problem is there is no initial notify and both task are awaiting in ulTaskNotifyTake: https://github.com/brainstorm/esp-modbus-power-meter/blob/broken_tasks/src/app_...
by brainstorm
Sat Oct 29, 2022 9:47 am
Forum: ESP-IDF
Topic: ESP-IDF FreeRTOS Task notification(s) code review?
Replies: 8
Views: 3054

ESP-IDF FreeRTOS Task notification(s) code review?

Is there a forum to ask for code reviews for ESP-IDF application code? Anyways, I'm having some problems putting together Direct Task Notification scheme between two tasks: pvoutput and modbus over here: https://github.com/brainstorm/esp-modbus-power-meter/blob/broken_tasks/src/app_modbus.c https://...
by brainstorm
Sat Oct 15, 2022 11:06 am
Forum: ESP-IDF
Topic: Project compiling with both PlatformIO and native idf.py ESP-IDF tooling?
Replies: 4
Views: 3036

Re: Project compiling with both PlatformIO and native idf.py ESP-IDF tooling?

EDIT: All fixed in https://github.com/brainstorm/esp-modbus-power-meter/commit/6520d32dc93cbe00fc9edb117dcc57f888515441, thanks Ivan! :) Fixed all the remaining issues on this range of commits!: https://github.com/brainstorm/esp-modbus-power-meter/compare/f4a9b7afcc9a6206cf13e822c3b708d4697b2473..d4...
by brainstorm
Sat Oct 15, 2022 7:10 am
Forum: ESP-IDF
Topic: Project compiling with both PlatformIO and native idf.py ESP-IDF tooling?
Replies: 4
Views: 3036

Re: Project compiling with both PlatformIO and native idf.py ESP-IDF tooling?

Ivan, first of all, thanks for your invaluable help! A couple of days ago, I reported the esp-insights error you mention and Vikram got it fixed and pushed upstream for me: https://github.com/espressif/esp-insights/issues/12 I should have merged those changes before asking in here, my bad. Now they ...
by brainstorm
Fri Oct 14, 2022 5:03 am
Forum: ESP-IDF
Topic: Project compiling with both PlatformIO and native idf.py ESP-IDF tooling?
Replies: 4
Views: 3036

Project compiling with both PlatformIO and native idf.py ESP-IDF tooling?

Hi, I'm trying to refresh a ModBus+Power metering+Rainmaker/PVOutput hobby project of mine: https://github.com/brainstorm/esp-modbus-power-meter/ The refresh I was thinking about consists on leaving PlatformIO part of it working with ESP-IDF 4.4 while transitioning to ESP-IDF 5.x SDK series. My main...
by brainstorm
Fri Apr 08, 2022 4:26 am
Forum: ESP-IDF
Topic: Modbus power meter working with eModbus (Arduino), need insight(s) for FreeModbus (ESP-IDF)
Replies: 9
Views: 5714

Re: Modbus power meter working with eModbus (Arduino), need insight(s) for FreeModbus (ESP-IDF)

I've found out that the manual I just scanned and posted here is for the meter with model number YG899E-9SY, which does not correspond with my yigedianqi-modbus CID table because tha CID table I've written in my code is for model YG194E-9SY. Both model's parameters seem to be laid out (correctly?) o...
by brainstorm
Tue Apr 05, 2022 12:42 am
Forum: ESP RainMaker
Topic: app_insights: Nodes with Self Claiming may not be accessible for Insights... and some UX questions about the platform
Replies: 2
Views: 3089

Re: app_insights: Nodes with Self Claiming may not be accessible for Insights... and some UX questions about the platfor

Thanks for the detailed explanation, all doubts cleared, I will experiment further with that guidance :) Now, if I may, I have one more question: I saw in the roadmap that timeseries is a planned feature and I've seen some hints on the properties of the API (i.e: PROP_FLAG_TIME_SERIES). In my (solar...