Potential serious issue with MQTT library in ESP-IDF 3.2 - resolved by Espressif?

meowsqueak
Posts: 133
Joined: Thu Jun 15, 2017 4:54 am
Location: New Zealand

Potential serious issue with MQTT library in ESP-IDF 3.2 - resolved by Espressif?

Postby meowsqueak » Tue Mar 19, 2019 9:23 pm

In the thread ESP-IDF V3.2-beta3 has been released I see "Integrated esp-mqtt MQTT client library into ESP-IDF". This is good progress - the IDF could do with an official MQTT client - but I'm very concerned about this outstanding issue in that particular library:

https://github.com/espressif/esp-mqtt/issues/18

It concerns mishandling of data reads from the TCP socket, by assuming that any pending data only contains a single packet. In fact it can contain any number of packets, but the code (when I evaluated it over a year ago) would drop all but the first. As far as I can see it has not been properly resolved. If an application is only sending or receiving occasional MQTT messages it seldom arises, but if you send it many messages (such as I was originally doing via an OSC to MQTT bridge) then it results in many dropped messages.

I'd like to use this library if it's now officially to be part of the ESP-IDF, but I'd like an assertion from an Espressif engineer that this issue has been investigated and resolved in the Espressif fork, please.

Incidentally, I have been using this library instead: 256dpi/esp-mqtt

ESP_cermak
Posts: 37
Joined: Thu Nov 01, 2018 8:32 am

Re: Potential serious issue with MQTT library in ESP-IDF 3.2 - resolved by Espressif?

Postby ESP_cermak » Wed Mar 20, 2019 10:53 am

Hi

Yes these issues are resolved in these commits:
https://github.com/espressif/esp-mqtt/c ... aa0301baaf
https://github.com/espressif/esp-mqtt/c ... a209af2d11
https://github.com/espressif/esp-mqtt/c ... 09e0e71d8a

I can see that current v3.2 branch still points to earlier commits in esp-mqtt, but will backport submodule update.

meowsqueak
Posts: 133
Joined: Thu Jun 15, 2017 4:54 am
Location: New Zealand

Re: Potential serious issue with MQTT library in ESP-IDF 3.2 - resolved by Espressif?

Postby meowsqueak » Wed Mar 20, 2019 8:23 pm

Thank you very much for the detailed reply. I look forward to using this library in 3.2.

Who is online

Users browsing this forum: Atul_90 and 15 guests